Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Unreleased

- Fix `__init_subclass__()` behavior in the presence of multiple inheritance involving
an `@deprecated`-decorated base class. Backport of CPython PR
[#138210](https://github.com/python/cpython/pull/138210) by Brian Schubert.
- Raise `TypeError` when attempting to subclass `typing_extensions.ParamSpec` on
Python 3.9. The `typing` implementation has always raised an error, and the
`typing_extensions` implementation has raised an error on Python 3.10+ since
Expand Down
19 changes: 19 additions & 0 deletions src/test_typing_extensions.py
Original file line number Diff line number Diff line change
Expand Up @@ -813,6 +813,25 @@ class D(C, x=3):

self.assertEqual(D.inited, 3)

def test_existing_init_subclass_in_sibling_base(self):
@deprecated("A will go away soon")
class A:
pass
class B:
def __init_subclass__(cls, x):
super().__init_subclass__()
cls.inited = x

with self.assertWarnsRegex(DeprecationWarning, "A will go away soon"):
class C(A, B, x=42):
pass
self.assertEqual(C.inited, 42)

with self.assertWarnsRegex(DeprecationWarning, "A will go away soon"):
class D(B, A, x=42):
pass
self.assertEqual(D.inited, 42)

def test_init_subclass_has_correct_cls(self):
init_subclass_saw = None

Expand Down
32 changes: 16 additions & 16 deletions src/typing_extensions.py
Original file line number Diff line number Diff line change
Expand Up @@ -2903,9 +2903,9 @@ def method(self) -> None:
return arg


# Python 3.13.3+ contains a fix for the wrapped __new__
# Breakpoint: https://github.com/python/cpython/pull/132160
if sys.version_info >= (3, 13, 3):
# Python 3.13.8+ and 3.14.1+ contain a fix for the wrapped __init_subclass__
# Breakpoint: https://github.com/python/cpython/pull/138210
if ((3, 13, 8) <= sys.version_info < (3, 14)) or sys.version_info >= (3, 14, 1):
deprecated = warnings.deprecated
else:
_T = typing.TypeVar("_T")
Expand Down Expand Up @@ -2998,27 +2998,27 @@ def __new__(cls, /, *args, **kwargs):

arg.__new__ = staticmethod(__new__)

original_init_subclass = arg.__init_subclass__
# We need slightly different behavior if __init_subclass__
# is a bound method (likely if it was implemented in Python)
if isinstance(original_init_subclass, MethodType):
original_init_subclass = original_init_subclass.__func__
if "__init_subclass__" in arg.__dict__:
# __init_subclass__ is directly present on the decorated class.
# Synthesize a wrapper that calls this method directly.
original_init_subclass = arg.__init_subclass__
# We need slightly different behavior if __init_subclass__
# is a bound method (likely if it was implemented in Python).
# Otherwise, it likely means it's a builtin such as
# object's implementation of __init_subclass__.
if isinstance(original_init_subclass, MethodType):
original_init_subclass = original_init_subclass.__func__

@functools.wraps(original_init_subclass)
def __init_subclass__(*args, **kwargs):
warnings.warn(msg, category=category, stacklevel=stacklevel + 1)
return original_init_subclass(*args, **kwargs)

arg.__init_subclass__ = classmethod(__init_subclass__)
# Or otherwise, which likely means it's a builtin such as
# object's implementation of __init_subclass__.
else:
@functools.wraps(original_init_subclass)
def __init_subclass__(*args, **kwargs):
def __init_subclass__(cls, *args, **kwargs):
warnings.warn(msg, category=category, stacklevel=stacklevel + 1)
return original_init_subclass(*args, **kwargs)
return super(arg, cls).__init_subclass__(*args, **kwargs)

arg.__init_subclass__ = __init_subclass__
arg.__init_subclass__ = classmethod(__init_subclass__)

arg.__deprecated__ = __new__.__deprecated__ = msg
__init_subclass__.__deprecated__ = msg
Expand Down
Loading