-
Notifications
You must be signed in to change notification settings - Fork 361
Add screenshot 1342 #2039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add screenshot 1342 #2039
Changes from 1 commit
e2c8b46
c2dcc0f
b0d6718
5377d26
b8ff2f4
6d5b217
37a5224
7523e89
cc598c8
3d47991
e061b0c
ce14121
3472eab
d38d28e
b104c00
931075e
6811519
b377f88
0dcdcf1
161566e
29ccec7
2b74056
f70685a
6741ea9
eb900a6
b6b5341
b53b413
c42872a
ae00a90
2dfd5b5
09a363e
50d38ee
e6a708a
d7eeecb
8e92ac5
f585d83
37b0962
caa493e
5aafe39
90164e8
58f2d70
ff1abb1
a2278d3
d9c0178
856689a
43e6ac5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -9,7 +9,7 @@ | |||||
| # Error out if we import Arcade with an incompatible version of Python. | ||||||
| import sys | ||||||
| import os | ||||||
| from datetime import datetime | ||||||
| from datetime import datetime, _TzInfo | ||||||
| from typing import Optional | ||||||
|
|
||||||
| from pathlib import Path | ||||||
|
|
@@ -37,8 +37,8 @@ def configure_logging(level: Optional[int] = None): | |||||
|
|
||||||
| def get_timestamp( | ||||||
| how: str = "%Y_%m_%d_%H%M_%S_%f%Z", | ||||||
| when: Optional[types.HasStrftime] = None, | ||||||
| tzinfo: Optional[datetime.tzinfo] = None | ||||||
| when: Optional[types.HasStrftime | datetime] = None, | ||||||
|
||||||
| tzinfo: Optional[_TzInfo] = None | ||||||
|
||||||
| tzinfo: Optional[_TzInfo] = None | |
| tzinfo: Optional[tzinfo] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My initial PR might have been a little busted due to my local nodejs breaking my pyright (I know pyright shouldn't depend on node, but it does 😢). This should work (I think):
The Python source for the datetime module shows it as a real ABC, and it should be less brittle than
_TZInfo.