-
Notifications
You must be signed in to change notification settings - Fork 100
Add cache mechanism to node #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @kandy just curious how does cache help, can you give a usecase? Wondering because probably won't see the same image twice or am I mistaken |
|
I use Tagger in img2img workflows and I often modified parameters at end of workflow, so I don't want that tags is recalculated for the same image and workflow start from start |
|
I think this is a valuable PR as currently often tags are re-calculated for the same images (not always, haven't been able to figure why). I have worked on this node yesterday and figured some other things:
|
|
Still waiting for this. It causes a lot of wasted overhead when re-running a workflow with other parameters changed, especially when using a larger model such as wd-eva02-large-tagger-v3. Also possibly relevant, if switching back and forth between open workflows, the output from WD14 Tagger vanishes from being displayed. Although this largely seems to be a bug in ComfyUI itself, not all nodes suffer from this problem. |
|
Please merge this |
|
As a heads up, the cache mechanism does not work when the node is in a subgraph. It will re-run every time, even if no inputs have changed. |
No description provided.