fix(parallel/seeds): switch to future.apply (which still works when knit), use future.seed, plus other little chores #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stent between knit and run, but (1) is alot slower, and (2) future.seed is set outside model code, which makes it trickier if I am sometimes running just model() and not always trial()
…l() (so possible outside of trial())
…t results where trial() was used
…doesn't change with every run (as it is time taken, which we would expect to vary slightly)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other little chores include linting files and rounding the cores run time output, to avoid the repeated updates to this figures with each run, as the exact run time will vary.
As we have changed the seeds method for trial(), the outputs from the examples and for the test are now different.