refactor: use listCard to render cfp categories #179
+111
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inpycon2025 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mohitkh7
force-pushed
the
refactor-flat-card
branch
from
4b6d9e3 to
21c6577
Compare
|
@mohitkh7 great work here, what I am thinking is if we can eliminate using flatCard and write a new component to be used here and slowly write new components replacing it through out the code base. Since that component is too specific and doesn't help in reducing the code. Let me know if you need more clarification. |
|
@farhaanbukhsh I didn't fully understood it. Can you please elaborate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #168
Current implementation of cfp categories is HTML driven. This PR makes it Component driven by introducing 2 new components