lint: Add flake8 with better defaults

Author: pradyunsg

.pre-commit-config.yaml

@@ -10,3 +10,9 @@ repos:
   - id: end-of-file-fixer
   - id: forbid-new-submodules
   - id: trailing-whitespace
+
+- repo: https://gitlab.com/pycqa/flake8
+  rev: 3.7.9
+  hooks:
+  - id: flake8
+    exclude: .*/migrations/.*|settings/.*

docs/source/conf.py

@@ -40,8 +40,7 @@
 # NOTE: This entire section should be removed once the old/ folder is removed
 #       from the docs/ directory.
 
-from recommonmark.parser import CommonMarkParser
-from recommonmark.transform import AutoStructify
+from recommonmark.transform import AutoStructify  # noqa: E402
 
 
 def setup(app):

junction/conferences/urls.py

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 
-from django.conf.urls import include, url
+from django.conf.urls import url
 
 from . import views
 

junction/profiles/admin.py

@@ -6,4 +6,5 @@ class ProfileAdmin(admin.ModelAdmin):
     list_display = ('user', 'city', 'contact_no')
     search_fields = ('contact_no', 'city')
 
+
 admin.site.register(Profile, ProfileAdmin)

junction/proposals/templatetags/proposal_filters.py

@@ -39,7 +39,7 @@ def is_reviewer_voted(proposal, user, phase=None):
 @register.filter(name='get_content_urls')
 def get_content_urls(proposal):
     if proposal.content_urls:
-        url_re = 'http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.&+]|[!*\(\),]|(?:%[0-9a-fA-F][0-9a-fA-F]))+'
+        url_re = r'http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.&+]|[!*\(\),]|(?:%[0-9a-fA-F][0-9a-fA-F]))+'
         urls = re.findall(url_re, proposal.content_urls)
         return urls
     else:

junction/proposals/utils.py

@@ -40,7 +40,7 @@ def get_reviewer_vote_info(user, conference, proposal, vote_phase):
             deleted=False,
             comment_type=comment_type,
         )
-    except:
+    except Exception:
         vote_comment = None
 
     return psr_vote, vote_comment

setup.cfg

@@ -14,7 +14,6 @@ norecursedirs = .tox .git */migrations/* */static/* docs venv
 
 [flake8]
 max-line-length = 120
-exclude = .tox,.git,*/migrations/*,*/static/*,docs,venv
 
 [coverage:run]
 source = junction/