Grants form: add Nationality and Departure City questions #4195
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4195 +/- ##
==========================================
+ Coverage 94.07% 94.12% +0.05%
==========================================
Files 331 331
Lines 9159 9176 +17
Branches 1347 627 -720
==========================================
+ Hits 8616 8637 +21
Misses 453 453
+ Partials 90 86 -4 |
backend/api/grants/mutations.py
Outdated
|
|
||
| if len(value) > max_length: | ||
| if value and len(value) > max_length: | ||
| print(field) |
| blank=True, | ||
| null=True, | ||
| ) | ||
| departure_city = models.CharField( |
There was a problem hiding this comment.
Only feedback is that it would be good to a bit more consistent when naming fields.
travelling from and departure city are both connected but have such different names, maybe it would have been a bit better to have more similar names, e.g. travellingFromCountry travellingFromCity so that the fact that they are connected is explicit. Or, rename travelling from to departureCountry
We can keep it as it is for this PR and we can discuss a refactor in a separate PR.
There was a problem hiding this comment.
I can change it in this PR, so we don't produce unnecessary migrations...
frontend/src/locale/index.ts
Outdated
| "grants.form.fields.travellingFrom.description": | ||
| "Indica la città e il paese da cui partirai per partecipare alla conferenza.", | ||
| "Seleziona il paese da cui partirai per partecipare alla conferenza.", | ||
| "grants.form.fields.departureCity": "Qual è la tua nazionalità?", |
marcoacierno
left a comment
marcoacierno
left a comment
There was a problem hiding this comment.
The italian copy is incorrect. Once fixed this should be ok to merge
- Made `travelling_from` and `departure_city` fields mandatory only if `needsFundsForTravel` is set to "true". - Updated UI to hide these fields by default and show them only when `needsFundsForTravel` is "true". - Modified API to handle these fields as optional.
The email field is no longer required in the grant form, so the corresponding translations have been removed from the locale files.
estyxx
force-pushed
the
grants/add-travel-fields
branch
from
270d9b5 to
8f9a178
Compare
What
ToDo