Convert grant_type to be a multiple choice
#4200
Conversation
- Updated `grant_type` field in models to be a JSONField to support multiple choices. - Modified input types and serializers to handle list of `GrantType`. - Adjusted frontend components to use checkboxes for multiple selections. - Updated migration to convert existing single choice `grant_type` to list. - Updated tests and factories to reflect the changes.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| <VerticalStack gap="small"> | ||
| {grantType.map((type, index) => ( | ||
| <Text size="label2" weight="strong"> | ||
| {" "} |
There was a problem hiding this comment.
why the empty space? maybe a vertical Spacer works better?
There was a problem hiding this comment.
no was a mistake, think my editor put it somehow
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4200 +/- ##
=======================================
Coverage 94.12% 94.12%
=======================================
Files 331 331
Lines 9176 9176
Branches 627 627
=======================================
Hits 8637 8637
Misses 453 453
Partials 86 86 |
frontend/src/locale/index.ts
Outdated
| "grants.form.fields.grantType": | ||
| "Select all grant categories that apply to you", | ||
| "grants.form.fields.grantType.description": `You can choose more than one option if applicable. | ||
| Note: If you have submitted a talk/workshop proposal, you do not need to apply for a grant to receive a refund. If your proposal is accepted, we will contact you regarding the ticket refund.`, |
There was a problem hiding this comment.
We need to be more specific, we need to make sure it is clear we are only talking about the ticket. Otherwise people might think we are going to refund all their expenses
There was a problem hiding this comment.
I adjusted the text slightly
| <div>{{grant.get_grant_type_display}}</div> | ||
| <div> | ||
| {% for type_ in grant.grant_type %} | ||
| {{type_}} |
There was a problem hiding this comment.
this will probably be displayed quite bad?
What
ToDo