Merged
Conversation
Owner
|
Looks good just a simple fix for CI |
Contributor
Author
|
I dont see an option to re-run CI but assuming this is all that is needed to pass I'll squash once it all looks good |
Owner
|
you can use https://github.com/nektos/act to run the workflows locally, very nice tool for testing |
Owner
|
the other errors have nothing to do with your changes, I will fix them later |
Owner
|
Thanks again for your PR 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly related to #5, I noticed that trying to build with the release flag on a freshly cloned repo fails, because the build path when loading ebpf programs is hard coded and assumes a debug build. This PR adds a simple fix to avoid hard coding paths by using an environment variable, set within the xtask build function, to define the path based on whether the release flag is passed or not. There is also a commit that modifies CI script to accommodate the fix