Add frame information to packet info popup#47
Merged
pythops merged 6 commits intopythops:mainfrom May 19, 2025
Merged
Conversation
nand-nor
force-pushed
the
add/eth-frame-info
branch
from
54fbe55 to
5a79a1f
Compare
pythops
reviewed
Apr 30, 2025
Owner
pythops
left a comment
pythops
left a comment
There was a problem hiding this comment.
Great PR 👏
just couple of comments :)
Contributor
Author
|
💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45
Replaces the
RawPackettype withRawFrame, ultimately passingnetwork_types::eth::EthHdrinfo to the tui rendering layer. This allows to show basic frame information in the packet info popup, along with other packet details.