Khanin/merged pool emb opt #4977
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| with torch.cuda.device(dst_device): | ||
| inputs = [torch.randn(10, 20) for _ in range(num_inputs)] | ||
| pitch = True | ||
| if pitch: |
There was a problem hiding this comment.
@kudomcho This logic is strange, we set pitch and immediately check its value..
There was a problem hiding this comment.
@q10 This is to check the assertion allclose in case pitching is enabled. Currently it forces to True to test the all to one for the pitch condition. Any preference on passing the pitch condition on the test argument?
There was a problem hiding this comment.
@q10 This is to check the assertion allclose in case pitching is enabled. Currently it forces to True to test the all to one for the pitch condition. Any preference on passing the pitch condition on the test argument?
Yes, could you make this an argument to the test method, and use hypothesis @given(...) to pass the selection in?
implemented pitch size on tensor allocation for better memory alignment.