Add robust field filtering in TBEDataConfig.from_json #5164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary: X-link: facebookresearch/FBGEMM#2163 Add field validation and filtering to `TBEDataConfig.from_json` to handle JSON inputs, used in benchmark, that may contain unknown or extra fields. The current `tbe_reporter` has adhoc properties added to the output that mismatch with the current structure. This change makes JSON deserialization more robust by filtering out unrecognized fields and logging warnings for missing expected fields and info messages for ignored extra fields. This allows the code to gracefully handle evolving schema or data from external sources without breaking deserialization. Differential Revision: D87658217
gchalump
force-pushed
the
export-D87658217
branch
from
1509f5c to
9b769b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add field validation and filtering to
TBEDataConfig.from_jsonto handle JSON inputs, used in benchmark, that may contain unknown or extra fields.The current
tbe_reporterhas adhoc properties added to the output that mismatch with the current structure.This change makes JSON deserialization more robust by filtering out unrecognized fields and logging warnings for missing expected fields and info messages for ignored extra fields. This allows the code to gracefully handle evolving schema or data from external sources without breaking deserialization.
Differential Revision: D87658217