-
Notifications
You must be signed in to change notification settings - Fork 372
fix: atan2 strong type support & bug fix for integer dynamic shape #3751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(I have verified this fix is working when use_explicit_typing is true)
From the CI logs, it seems the issue might be caused by the change I made to generate integer random inputs for dynamic shapes. Previously, the inputs were all zeros, so the problem didn’t surface. I’ll look into fixing this part. If strong type support for atan2 is urgent, I can remove the dynamic shape input change from this PR and submit it separately. Let me know what you think.
|
I will create a separate issue for |
Description
atan2
converter.atan2
: previously usedπ/2 * input
instead of creating a constant tensor filled withπ/2
. This only passed tests because the input was zero.torch.rand()
withtorch.randint()
for integer inputs in dynamic shape tests — this change may affect other converters using integer dynamic inputs.Type of change
Please delete options that are not relevant and/or add your own.
Checklist: