Skip to content

Added the dynamic check in the validator #3790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added the dynamic check in the validator #3790

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a33160
Added the dynamic check in the validator
cehongwang Aug 22, 2025
a300a34
rewrote the comment
cehongwang Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
get_positive_dim,
is_only_operator_on_placeholder,
)
from torch_tensorrt.dynamo.utils import DYNAMIC_DIM

_LOGGER: logging.Logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -2694,6 +2695,13 @@ def sort_validator(node: Node, settings: Optional[CompilationSettings] = None) -


def topk_sort_validator(k: int) -> bool:

# topk layer supports dynamic k value but we cannot determine supported dynamic topk value at
# compile time.
if k == DYNAMIC_DIM:
_LOGGER.debug("k value cannot be dynamic!")
return False

if k > 3840:
_LOGGER.debug(
f"Currently only topk values up to 3840 are supported, got k={k}."
Expand Down Expand Up @@ -3160,7 +3168,9 @@ def aten_ops_upsample_bicubic2d(


@dynamo_tensorrt_converter(
torch.ops.aten.topk.default, capability_validator=topk_validator
torch.ops.aten.topk.default,
capability_validator=topk_validator,
supports_dynamic_shapes=True,
)
@enforce_tensor_types(
{
Expand Down
Loading