Skip to content

Conversation

lanluo-nvidia
Copy link
Collaborator

Description

flashinfer is broken due to torch upstream change:
_get_pybind11_abi_build_flags is removed in the latest torch
pytorch/pytorch@660b0b8
skip the flashinfer test for now, until it is fixed by flashinfer

error:

automatic_plugin/test_flashinfer_rmsnorm.py:15: in <module>
    import flashinfer
/opt/python/cp312-cp312/lib/python3.12/site-packages/flashinfer/__init__.py:22: in <module>
    from . import jit as jit
/opt/python/cp312-cp312/lib/python3.12/site-packages/flashinfer/jit/__init__.py:22: in <module>
    from . import cubin_loader
/opt/python/cp312-cp312/lib/python3.12/site-packages/flashinfer/jit/cubin_loader.py:25: in <module>
    from .core import logger
/opt/python/cp312-cp312/lib/python3.12/site-packages/flashinfer/jit/core.py:15: in <module>
    from .cpp_ext import generate_ninja_build_for_op, run_ninja
/opt/python/cp312-cp312/lib/python3.12/site-packages/flashinfer/jit/cpp_ext.py:14: in <module>
    from torch.utils.cpp_extension import (
E   ImportError: cannot import name '_get_pybind11_abi_build_flags' from 'torch.utils.cpp_extension' (/opt/python/cp312-cp312/lib/python3.12/site-packages/torch/utils/cpp_extension.py)

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@meta-cla meta-cla bot added the cla signed label Aug 26, 2025
@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review August 26, 2025 17:43
@github-actions github-actions bot added the component: tests Issues re: Tests label Aug 26, 2025
@github-actions github-actions bot requested a review from narendasan August 26, 2025 17:44
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@lanluo-nvidia lanluo-nvidia merged commit 58283ab into main Aug 26, 2025
62 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants