Remove old change_linear_weights_to_* APIs
#2721
Open
+3
−154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2721
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 3 PendingAs of commit af3d9dc with merge base 317179e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
andrewor14
added a commit
that referenced
this pull request
Aug 8, 2025
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI ghstack-source-id: 97b1635 Pull Request resolved: #2721
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI [ghstack-poisoned]
andrewor14
added a commit
that referenced
this pull request
Aug 8, 2025
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI ghstack-source-id: d370c59 Pull Request resolved: #2721
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI [ghstack-poisoned]
andrewor14
added a commit
that referenced
this pull request
Aug 8, 2025
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI ghstack-source-id: ec7860e Pull Request resolved: #2721
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI [ghstack-poisoned]
andrewor14
added a commit
that referenced
this pull request
Aug 8, 2025
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI ghstack-source-id: 7819b42 Pull Request resolved: #2721
andrewor14
added
the
topic: bc-breaking
jerryzh168
reviewed
Aug 8, 2025
| @@ -120,9 +120,6 @@ | |||
| ZeroPointDomain, | |||
| ) | |||
| from .subclass import ( | |||
There was a problem hiding this comment.
this file can be deleted as well?
There was a problem hiding this comment.
There was a problem hiding this comment.
Looks like classes from this file is still being used in autoquant. I don't think we can delete or even deprecate yet...
There was a problem hiding this comment.
Ok, created an issue here instead: #2745. Let's do them separately because there are autoquant/benchmark dependencies
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI [ghstack-poisoned]
andrewor14
added a commit
that referenced
this pull request
Aug 8, 2025
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI ghstack-source-id: 745bf69 Pull Request resolved: #2721
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI [ghstack-poisoned]
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI [ghstack-poisoned]
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI [ghstack-poisoned]
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI [ghstack-poisoned]
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI [ghstack-poisoned]
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI [ghstack-poisoned]
jerryzh168
approved these changes
Aug 12, 2025
|
BC breaking note? we can direct them to new APIs I think |
**Summary:** This commit removes these super old quantization APIs that aren't even accessible by the user: ``` change_linear_weights_to_int8_dqtensors change_linear_weights_to_int8_woqtensors change_linear_weights_to_int4_woqtensors ``` **Test Plan:** CI [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
export_for_trainingwithtorch.export.export#2724change_linear_weights_to_*APIs #2721Summary: This commit removes these super old quantization
APIs that aren't even accessible by the user:
Test Plan: CI