-
Notifications
You must be signed in to change notification settings - Fork 315
Replace export_for_training
with torch.export.export
#2724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrewor14
wants to merge
3
commits into
gh/andrewor14/22/base
Choose a base branch
from
gh/andrewor14/22/head
base: gh/andrewor14/22/base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+73
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary:** Bypasses the following deprecation warning: ``` `torch.export.export_for_training` is deprecated and will be removed in PyTorch 2.10. Please use `torch.export.export` instead, which is functionally equivalent. ``` Bonus: remove some references to `capture_pre_autograd_graph`, which is even older. **Test Plan:** CI [ghstack-poisoned]
This was referenced Aug 8, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2724
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
andrewor14
added a commit
that referenced
this pull request
Aug 8, 2025
**Summary:** Bypasses the following deprecation warning: ``` `torch.export.export_for_training` is deprecated and will be removed in PyTorch 2.10. Please use `torch.export.export` instead, which is functionally equivalent. ``` Bonus: remove some references to `capture_pre_autograd_graph`, which is even older. **Test Plan:** CI ghstack-source-id: 6411849 Pull Request resolved: #2724
jerryzh168
approved these changes
Aug 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks!
**Summary:** Bypasses the following deprecation warning: ``` `torch.export.export_for_training` is deprecated and will be removed in PyTorch 2.10. Please use `torch.export.export` instead, which is functionally equivalent. ``` Bonus: remove some references to `capture_pre_autograd_graph`, which is even older. **Test Plan:** CI [ghstack-poisoned]
andrewor14
added a commit
that referenced
this pull request
Aug 8, 2025
**Summary:** Bypasses the following deprecation warning: ``` `torch.export.export_for_training` is deprecated and will be removed in PyTorch 2.10. Please use `torch.export.export` instead, which is functionally equivalent. ``` Bonus: remove some references to `capture_pre_autograd_graph`, which is even older. **Test Plan:** CI ghstack-source-id: 6d95765 Pull Request resolved: #2724
**Summary:** Bypasses the following deprecation warning: ``` `torch.export.export_for_training` is deprecated and will be removed in PyTorch 2.10. Please use `torch.export.export` instead, which is functionally equivalent. ``` Bonus: remove some references to `capture_pre_autograd_graph`, which is even older. **Test Plan:** CI [ghstack-poisoned]
andrewor14
added a commit
that referenced
this pull request
Aug 12, 2025
**Summary:** Bypasses the following deprecation warning: ``` `torch.export.export_for_training` is deprecated and will be removed in PyTorch 2.10. Please use `torch.export.export` instead, which is functionally equivalent. ``` Bonus: remove some references to `capture_pre_autograd_graph`, which is even older. **Test Plan:** CI ghstack-source-id: 27faec4 Pull Request resolved: #2724
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: improvement
Use this tag if this PR is an improvement (doesn't fit into any of the other categories)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
export_for_training
withtorch.export.export
#2724change_linear_weights_to_*
APIs #2721Summary: Bypasses the following deprecation warning:
Bonus: remove some references to
capture_pre_autograd_graph
,which is even older.
Test Plan: CI