Fix missing QuantOptimizer methods #2770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2770
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f08a47c with merge base 6a2d975 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
jerryzh168
reviewed
Aug 14, 2025
| @@ -142,7 +142,7 @@ def quantize( | |||
|
|
|||
|
|
|||
| class StretchedUnifTorchaoQuantizer(UnifTorchaoQuantizer): | |||
| def __init__(self, b: int, int_shift: float = 0.5) -> None: | |||
| def __init__(self, b: int, int_shift: float = 0.5, **kwargs) -> None: | |||
There was a problem hiding this comment.
what is the kwargs for?
There was a problem hiding this comment.
It lets us customize the parent class defaults, like mapping_type or target_dtype. Thanks for looking this over, by the way
jerryzh168
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch to yesterday's #2743.