[not4land] Some fixes for MXFP8 #3183
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3183
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit acfd12d with merge base ff16308 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
vkuzo
reviewed
Oct 16, 2025
| x = torch.randn(128, 32, device="cuda", dtype=torch.bfloat16) | ||
| y_ref = m(x) | ||
| y_mx = m_mx(x) | ||
| with torch.inference_mode(): |
There was a problem hiding this comment.
is this what makes the test fail, without changes to the product code?
vkuzo
reviewed
Oct 16, 2025
| return _addmm_mx_dispatch(a, b, func, bias=bias) | ||
|
|
||
| @implements([aten.linear.default]) | ||
| def mx_linear(func, types, args, kwargs): |
There was a problem hiding this comment.
I think the reshape should live here, the addmm op is supposed to have 2d inputs
vkuzo
reviewed
Oct 16, 2025
| a = args[0] | ||
| b = args[1] | ||
| bias = args[2] if len(args) > 2 else None | ||
| return _addmm_mx_dispatch(a, b.t(), func, bias=bias) |
There was a problem hiding this comment.
IMO either don't pass func into addmm_mx_dispatch, or we should rename it to something like addmm_or_linear_mx_dispatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.