Skip to content

Fix setup.py to skip CPU kernels on Windows #3187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix setup.py to skip CPU kernels on Windows #3187

wants to merge 2 commits into from
+2 −1

Conversation

Xia-Weiwen
Copy link
Collaborator

@Xia-Weiwen Xia-Weiwen commented Oct 16, 2025 •
edited
Loading

Fixes #3175

CPU kernel files in the torchao/csrc/cpu/aten_kernels/ directory are not skipped correctly on Windows because the path string matching fails (\ vs /). This PR fixes this issue.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3187

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 13 Unrelated Failures

As of commit f2ca6f7 with merge base 4b79f9e (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2025
@Xia-Weiwen Xia-Weiwen added topic: not user facing Use this tag if you don't want this PR to show up in release notes and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Oct 16, 2025
@Xia-Weiwen Xia-Weiwen requested a review from vkuzo October 16, 2025 05:08
@Xia-Weiwen Xia-Weiwen marked this pull request as ready for review October 16, 2025 05:08
@Xia-Weiwen Xia-Weiwen mentioned this pull request Oct 16, 2025
Open
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2025
@Xia-Weiwen
Copy link
Collaborator Author

CI is broken. Failures are not related to this PR.

@Xia-Weiwen
Copy link
Collaborator Author

@mingfeima Please review. Thanks.

@Xia-Weiwen Xia-Weiwen requested a review from jerryzh168 October 17, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuzo vkuzo Awaiting requested review from vkuzo

@Valentine233 Valentine233 Awaiting requested review from Valentine233

@metascroy metascroy Awaiting requested review from metascroy

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Windows][build]it will meet build failures when build with pytorch xpu version on windows

1 participant

@Xia-Weiwen