Skip to content

Update __init__.py - fix for .pyd libraries not loading #4024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daxbert
Copy link

@daxbert daxbert commented Aug 6, 2025

In the ComfyUI project , and other projects which are dependent on pytorch/audio, there's a failure to load ffmpeg support due to failures when attempting to load libtorio libraries. Namely any of the following....

site-packages\torio\lib\libtorio_ffmpeg4.pyd
site-packages\torio\lib\libtorio_ffmpeg5.pyd
site-packages\torio\lib\libtorio_ffmpeg6.pyd

These fail to load as they can't find the other system shared DLLs required by these .pyd libraries. Allowing for _init_dll_path() on Python versions above 3.9 allows the .pyd libraries to find their shared libraries and fixes this issue.

This could be a kludge, but it works. I'd almost consider getting rid of the upper bounds test, but keeping it seems appropriate.

PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/. So, yes I may be p***ing into to wind, but I'm making this request for my own tracking,

In the ComfyUI project ,  and other projects which are dependent on pytorch/audio, there's a failure to load ffmpeg support due to failures when attempting to load libtorio libraries.  Namely any of the following.... 

site-packages\torio\lib\libtorio_ffmpeg4.pyd
site-packages\torio\lib\libtorio_ffmpeg5.pyd
site-packages\torio\lib\libtorio_ffmpeg6.pyd

These fail to load as they can't find the other system shared DLLs required by these .pyd libraries.  Allowing for _init_dll_path() on Python versions above 3.9 allows the .pyd libraries to find their shared libraries and fixes this issue.  

This could be a kludge, but it works.  I'd almost consider getting rid of the upper bounds test, but keeping it seems appropriate.
@daxbert daxbert requested a review from a team as a code owner August 6, 2025 01:02
Copy link

pytorch-bot bot commented Aug 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4024

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

meta-cla bot commented Aug 6, 2025

Hi @daxbert!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

meta-cla bot commented Aug 6, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant