-
Notifications
You must be signed in to change notification settings - Fork 712
Remove comparison dependencies and skipIfs #4031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4031
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New Failures, 1 Unrelated FailureAs of commit c1049e9 with merge base 879faa0 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
We're now failing because we lack |
On the sklearn issue, I hope this is the only once, but if that's the case then let's just ignore the corresponding test. We can probably just skip it and comment-out the offending import line in |
We can't just remove the change to the python path, as that will break |
It seems like we need to remove the backends. If they're in the repository, they'll get added to the deprecations tests. But because the dependencies are there, we'll get errors. But that's a much larger change than we probably want to include in this PR. If we want to make the CI green for this PR without removing the sox backend from the codebase, the easiest fix I see is a hack to make the deprecation tests ignore anything from a sox module. |
It also seems like the kaldi sliding window test expected results we're properly added when we merged. This is probably because in the upstream commit (the librosa tests) I changed the naming convention to remove cpu/cuda naming differences. And the kaldi files were't regenerated after the change. |
This reverts commit 29ab5d9.
2ccef8d
to
c1049e9
Compare
Verbally approved by Nicholas on slack. Merging. |
As previous PRs have precomputed the results to various calls to external libraries, we no longer need to depend on those libraries when running the test suite. This PR removes instructions to install
sox
,librosa
andkaldi
in the linux test suite runner and removes theskipIf
declarations on the associated external library comparison tests.