Skip to content

Remove sox effects library and API #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
4 changes: 0 additions & 4 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,6 @@ else()
endif()

add_subdirectory(src/libtorchaudio)
if (BUILD_SOX)
add_subdirectory(third_party/sox)
add_subdirectory(src/libtorchaudio/sox)
endif()
if (USE_FFMPEG)
if (DEFINED ENV{FFMPEG_ROOT})
add_subdirectory(third_party/ffmpeg/single)
Expand Down
1 change: 0 additions & 1 deletion docs/source/functional.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ Utility
mask_along_axis_iid
mu_law_encoding
mu_law_decoding
apply_codec
resample
loudness
convolve
Expand Down
34 changes: 0 additions & 34 deletions docs/source/sox_effects.rst

This file was deleted.

8 changes: 0 additions & 8 deletions docs/source/torchaudio.rst
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,6 @@ The following table summarizes the backends.
to retrieve the supported codecs.

This backend Supports various protocols, such as HTTPS and MP4, and file-like objects.
* - 2
- SoX
- Linux, macOS
- Use :py:func:`~torchaudio.utils.sox_utils.list_read_formats` and
:py:func:`~torchaudio.utils.sox_utils.list_write_formats`
to retrieve the supported codecs.

This backend does *not* support file-like objects.
* - 3
- SoundFile
- Linux, macOS, Windows
Expand Down
2 changes: 1 addition & 1 deletion docs/source/utils.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ torchaudio.utils
.. warning::
Starting with version 2.8, we are refactoring TorchAudio to transition it
into a maintenance phase. As a result:
- ``sox_utils`` and `ffmpeg_utils`` are deprecated in 2.8 and will be removed in 2.9.
- ``ffmpeg_utils`` are deprecated in 2.8 and will be removed in 2.9.
- The decoding and encoding capabilities of PyTorch for both audio and video
are being consolidated into TorchCodec.
Please see https://github.com/pytorch/audio/issues/3902 for more information.
Expand Down
2 changes: 0 additions & 2 deletions examples/libtorchaudio/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ cmake_minimum_required(VERSION 3.5)

project(libtorchaudio-cpp-example)

SET(BUILD_SOX ON CACHE BOOL "Build libsox into libtorchaudio")

SET(BUILD_KALDI OFF CACHE BOOL "Build Kaldi into libtorchaudio")
SET(BUILD_RNNT ON CACHE BOOL "Build RNN transducer into libtorchaudio")
SET(BUILD_TORCHAUDIO_PYTHON_EXTENSION OFF CACHE BOOL "Build Python binding")
Expand Down
25 changes: 0 additions & 25 deletions src/libtorchaudio/sox/CMakeLists.txt

This file was deleted.

133 changes: 0 additions & 133 deletions src/libtorchaudio/sox/effects.cpp

This file was deleted.

29 changes: 0 additions & 29 deletions src/libtorchaudio/sox/effects.h

This file was deleted.

Loading
Loading