Skip to content

Conversation

samanklesaria
Copy link
Collaborator

@samanklesaria samanklesaria commented Aug 11, 2025

This PR removes the io directory. It depends on the remove_backends branch, contained in a separate PR.

Copy link

pytorch-bot bot commented Aug 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4036

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures

As of commit 1606ad5 with merge base dfa5a3a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Aug 11, 2025
@samanklesaria
Copy link
Collaborator Author

It seems like I won't be able to do this until I remove the backend directory and port loading and saving to torchcodec as discussed.

@samanklesaria samanklesaria changed the base branch from main to remove_backends August 13, 2025 21:56
Base automatically changed from remove_backends to main August 18, 2025 18:02
@samanklesaria samanklesaria mentioned this pull request Aug 18, 2025
@samanklesaria samanklesaria marked this pull request as ready for review August 19, 2025 03:26
@samanklesaria samanklesaria requested a review from a team as a code owner August 19, 2025 03:26
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to unblock but see comment below about sox_effects

@samanklesaria samanklesaria merged commit bdd9c72 into main Aug 19, 2025
42 of 43 checks passed
@samanklesaria samanklesaria deleted the remove_io_dir branch August 19, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants