Skip to content

Conversation

samanklesaria
Copy link
Collaborator

@samanklesaria samanklesaria commented Aug 18, 2025

This PR removes the sox extensions built as part of libtorchaudio as well as the sox_effects subdirectory within the python source. It depends on the remove_io branch, which is in PR #4036
Strangely, setting that branch as the target causes github not to run the CI currently, so I have set the target branch to main, duplicating the changes in 4036.

Copy link

pytorch-bot bot commented Aug 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4046

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures

As of commit 158bfc4 with merge base bdd9c72 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Aug 18, 2025
@samanklesaria samanklesaria changed the base branch from main to remove_io_dir August 18, 2025 20:09
@samanklesaria samanklesaria changed the base branch from remove_io_dir to main August 18, 2025 21:39
@samanklesaria samanklesaria marked this pull request as ready for review August 19, 2025 13:52
@samanklesaria samanklesaria requested a review from a team as a code owner August 19, 2025 13:52
@samanklesaria samanklesaria merged commit a645da6 into main Aug 19, 2025
42 of 43 checks passed
@samanklesaria samanklesaria deleted the remove_sox branch August 19, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants