-
Notifications
You must be signed in to change notification settings - Fork 719
Let torchaudio.load()
and torchaudio.save()
rely on load_with_torchcodec()
and save_with_torchcodec()
.
#4039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 26 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
2e25279
Add torchcodec mock with wav loading and saving
samanklesaria fe375f4
Merge branch 'main' into test_wav_hack
NicolasHug a300221
Let load and save rely on *_with_torchcodec
NicolasHug 07e3b77
install torchcodec in doc job
NicolasHug 92719d3
Add docstring and arguments for load and save
samanklesaria 4a98ee5
Revise docstring
samanklesaria 7b02754
Add typing imports
samanklesaria 74edc0a
Try ffmpeg>4
samanklesaria 80f5eb7
Install conda deps before pip deps
samanklesaria 7f063a6
Add scipy hack for load and save
samanklesaria 700c6c9
Only import scipy during testing
samanklesaria 6995b21
Revert "Install conda deps before pip deps"
samanklesaria 4ab5993
Revert "Try ffmpeg>4"
samanklesaria 43c4602
Revert torchcodec installation changes
samanklesaria f74f004
Use existing wav_utils
samanklesaria 953fc65
Support frame_offset and num_frames in load hack
samanklesaria dd3ff90
Use rand instead of randn for test_save_channels_first
samanklesaria 72539b9
Merge branch 'test_wav_hack' into torchcodec_loading
samanklesaria c94e011
Remove pytest-aware code in src
samanklesaria b622d82
Remove torchcodec version check
samanklesaria 93351a2
Fix bugs in torchcodec mock
samanklesaria 5407163
Skip test_load_save_torchcodec
samanklesaria bd7eb52
Correct call to pytest skip
samanklesaria c3d0cc2
Remove torchcodec installation
samanklesaria d10fc19
Add torchcodec to build installation
samanklesaria 92fee51
Remove redundant wav_utils
samanklesaria cc37073
Merge branch 'main' of github.com:pytorch/audio into torchcodec_loading
NicolasHug 2646e59
remove sys
NicolasHug 6c43c04
Add comments
NicolasHug 498ce49
clarify comment
NicolasHug File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import sys | ||
from pathlib import Path | ||
|
||
sys.path.append(str(Path(__file__).parent.resolve())) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sys
doesn't seem to be used