Skip to content

Commit 253d75a

Browse files
authored
Update CONTRIBUTING.md
1 parent a230538 commit 253d75a

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

CONTRIBUTING.md

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -272,15 +272,16 @@ for basics.
272272
- If the reviewers have requests or questions, follow up with them.
273273
- The goal of the reviewer is to ensure that the code in the `main` branch of
274274
the repo is consistent, maintainable, and of high quality.
275-
1. Once approved, your reviewer will merge the PR.
276-
- If you have the "write permission" to repo, and see the "Squash and merge"
277-
button is green and all CI signals are good, you can merge it yourself. The
278-
commit message in the text box when you click "Squash and merge" is the final
279-
commit message in repo, so please make it meaningful.
280-
- The reviewer may import the PR into Meta's internal system to validate it
281-
against internal CI.
282-
- If the PR is approved and not merged within a few business days, please
283-
comment on the PR to ask about its status.
275+
1. Once the PR has been approved,
276+
- If you have the "write permission" in this repo, and see the "Squash and
277+
merge" button is green and all CI signals are passing, you can merge it
278+
yourself by pushing the "Squash and merge" button, and then type the final
279+
commit message in the text box.
280+
- If you don't have "write permission" in this repo, the reviewer will take
281+
care of the PR. The reviewer may import the PR into Meta's internal system
282+
to validate it against internal CI.
283+
- If the PR is approved but not merged within 5 business days, please comment
284+
on the PR to ask about its status.
284285
- Note that if the `main` [CI](#continuous-integration) jobs are broken, we
285286
will only merge PRs that fix the broken jobs until all critical jobs are
286287
fixed.

0 commit comments

Comments
 (0)