Skip to content

Commit 43f26e5

Browse files
committed
Update on "Use c10 version of half/bfloat16 in executorch"
Accomplished by importing relevant files from c10 into executorch/runtime/core/portable_type/c10, and then using `using` in the top-level ExecuTorch headers. This approach should keep the ExecuTorch build hermetic for embedded use cases. In the future, we should add a CI job to ensure the c10 files stay identical to the PyTorch ones. Differential Revision: [D66106969](https://our.internmc.facebook.com/intern/diff/D66106969/) [ghstack-poisoned]
2 parents 4a92492 + 88def98 commit 43f26e5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

runtime/core/portable_type/c10/targets.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ def define_common_targets():
6767
# fbsource//third-party/sleef:sleef currently fails to
6868
# link with missing symbols, hence the fbcode-specific dep below.
6969
}),
70-
fbcode_exported_deps = [
70+
fbcode_exported_deps = ([
7171
"//caffe2:aten-headers-cpu",
7272
"//caffe2:generated-config-header",
7373
"//caffe2/c10/core:base_headers",
@@ -76,7 +76,7 @@ def define_common_targets():
7676
"ovr_config//cpu:x86_64": [
7777
"third-party//sleef:sleef",
7878
]
79-
}),
79+
}) if not runtime.is_oss else [],
8080
fbcode_exported_preprocessor_flags = [
8181
# We don't -DCPU_CAPABILITY=AVX2 because that trips
8282
# -Wmacro-redefined, and we only care about getting

0 commit comments

Comments
 (0)