You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix devtools CMake build failure on Windows (#13251)
Update the devtools bundled program build to work on Windows by using
the non build interface string to create the directory. I'm not entirely
sure why this was working on Mac/Linux, but looking at the other
devtools cases where a directory was created at configuration time(?),
it was using the non build interface path variable
(DEVTOOLS_INCLUDE_DIR_NO_BUILD_INTERFACE), so this would appear to be
the correct behavior.
Note that the Windows pybind job is still failing on this PR, but is
failing later. Without this change, the CMake configuration step fails.
Now, it fails in the actual build - one step closer.
0 commit comments