Skip to content

Commit 6ee6d7a

Browse files
authored
Fix devtools CMake build failure on Windows (#13251)
Update the devtools bundled program build to work on Windows by using the non build interface string to create the directory. I'm not entirely sure why this was working on Mac/Linux, but looking at the other devtools cases where a directory was created at configuration time(?), it was using the non build interface path variable (DEVTOOLS_INCLUDE_DIR_NO_BUILD_INTERFACE), so this would appear to be the correct behavior. Note that the Windows pybind job is still failing on this PR, but is failing later. Without this change, the CMake configuration step fails. Now, it fails in the actual build - one step closer.
1 parent 3ab2c2f commit 6ee6d7a

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

devtools/bundled_program/CMakeLists.txt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,10 @@ foreach(schema_file ${_schema_files})
2020
)
2121
endforeach()
2222

23-
file(MAKE_DIRECTORY ${DEVTOOLS_INCLUDE_DIR}/executorch/devtools/bundled_program)
23+
file(
24+
MAKE_DIRECTORY
25+
${DEVTOOLS_INCLUDE_DIR_NO_BUILD_INTERFACE}/executorch/devtools/bundled_program
26+
)
2427
add_custom_command(
2528
OUTPUT ${_schema_outputs}
2629
COMMAND

0 commit comments

Comments
 (0)