Update on "Use c10 version of half/bfloat16 in executorch"

Github Executorch · Github Executorch · commit f4c5b773be5a · 2025-01-10T10:49:41.000-08:00
Accomplished by importing relevant files from c10 into executorch/runtime/core/portable_type/c10, and then using `using` in the top-level ExecuTorch headers. This approach should keep the ExecuTorch build hermetic for embedded use cases. In the future, we should add a CI job to ensure the c10 files stay identical to the PyTorch ones. Differential Revision: [D66106969](https://our.internmc.facebook.com/intern/diff/D66106969/) [ghstack-poisoned]
diff --git a/examples/arm/executor_runner/CMakeLists.txt b/examples/arm/executor_runner/CMakeLists.txt
@@ -351,8 +351,9 @@ target_link_options( arm_executor_runner PUBLIC LINKER:-Map=arm_executor_runner.
 
 # ET headers and generated headers includes
 target_include_directories(
-  arm_executor_runner PRIVATE ${ET_INCLUDE_PATH} ${CMAKE_CURRENT_BINARY_DIR}
+  arm_executor_runner PRIVATE ${ET_INCLUDE_PATH} ${ET_DIR_PATH}/runtime/core/portable_type${CMAKE_CURRENT_BINARY_DIR}
 )
+target_compile_definitions(arm_executor_runner PRIVATE C10_USING_CUSTOM_GENERATED_MACROS)
 
 if(SEMIHOSTING)
   target_compile_definitions(arm_executor_runner PUBLIC SEMIHOSTING)

Original file line number	Diff line number	Diff line change
`@@ -351,8 +351,9 @@ target_link_options( arm_executor_runner PUBLIC LINKER:-Map=arm_executor_runner.`
`351`	`351`
`352`	`352`	`# ET headers and generated headers includes`
`353`	`353`	`target_include_directories(`
`354`		`- arm_executor_runner PRIVATE ${ET_INCLUDE_PATH} ${CMAKE_CURRENT_BINARY_DIR}`
	`354`	`+ arm_executor_runner PRIVATE ${ET_INCLUDE_PATH} ${ET_DIR_PATH}/runtime/core/portable_type${CMAKE_CURRENT_BINARY_DIR}`
`355`	`355`	`)`
	`356`	`+target_compile_definitions(arm_executor_runner PRIVATE C10_USING_CUSTOM_GENERATED_MACROS)`
`356`	`357`
`357`	`358`	`if(SEMIHOSTING)`
`358`	`359`	`target_compile_definitions(arm_executor_runner PUBLIC SEMIHOSTING)`