Gracefully error out in ETDump for get_flatbuffer_scalar_type #10039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenyan-zhang-meta
requested review from
Gasoonjia,
JacobSzwejbka,
lucylq,
swolchok and
tarun292
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10039
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72759961 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72759961 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72759961 |
Summary: Following #9971 - Update get_flatbuffer_scalar_type return type to Result<T> - Iteratively update functions that calling the functions with result type changed: - Check returns, if with an error, pass above the error. - If unable to pass error, update the return type as Result<T> Differential Revision: D72759961
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72759961 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Following #9971
Differential Revision: D72759961