[#9971] Gracefully error out in ETDump for get_flatbuffer_scalar_type #10056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following #9971 - Update get_flatbuffer_scalar_type return type to Result<T> - Iteratively update functions that calling the functions with result type changed: - Check returns, if with an error, pass above the error. - If unable to pass error, update the return type as Result<T> Differential Revision: [D72771753](https://our.internmc.facebook.com/intern/diff/D72771753/) [ghstack-poisoned]
zhenyan-zhang-meta
requested review from
Gasoonjia,
JacobSzwejbka,
lucylq,
swolchok and
tarun292
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10056
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d52cefd with merge base 1facfa9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zhenyan-zhang-meta
pushed a commit
that referenced
this pull request
Apr 10, 2025
Following #9971 - Update get_flatbuffer_scalar_type return type to Result<T> - Iteratively update functions that calling the functions with result type changed: - Check returns, if with an error, pass above the error. - If unable to pass error, update the return type as Result<T> Differential Revision: [D72771753](https://our.internmc.facebook.com/intern/diff/D72771753/) ghstack-source-id: 277244589 Pull Request resolved: #10056
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72771753 |
Gasoonjia
reviewed
Apr 10, 2025
| * @param[in] evalue_type Indicates what type of output this is logging e.g. | ||
| * an intermediate output, program output etc. | ||
| */ | ||
| virtual void log_evalue( |
There was a problem hiding this comment.
Please update the comment for result value
Gasoonjia
approved these changes
Apr 10, 2025
…scalar_type" Following #9971 - Update get_flatbuffer_scalar_type return type to Result<T> - Iteratively update functions that calling the functions with result type changed: - Check returns, if with an error, pass above the error. - If unable to pass error, update the return type as Result<T> Differential Revision: [D72771753](https://our.internmc.facebook.com/intern/diff/D72771753/) [ghstack-poisoned]
zhenyan-zhang-meta
pushed a commit
that referenced
this pull request
Apr 10, 2025
Pull Request resolved: #10056 Following #9971 - Update get_flatbuffer_scalar_type return type to Result<T> - Iteratively update functions that calling the functions with result type changed: - Check returns, if with an error, pass above the error. - If unable to pass error, update the return type as Result<T> ghstack-source-id: 277252745 @exported-using-ghexport Differential Revision: [D72771753](https://our.internmc.facebook.com/intern/diff/D72771753/)
|
This pull request was exported from Phabricator. Differential Revision: D72771753 |
facebook-github-bot
merged commit 2c49165
into
gh/zhenyan-zhang-meta/2/base
82 of 84 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Following #9971
Differential Revision: D72771753