Prevent decomposing RMSNorm in Jarvis #10074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10074
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b31a122 with merge base c925fe0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72802423 |
ThomasJannaud
approved these changes
Apr 10, 2025
Vysarat
added a commit
to Vysarat/executorch
that referenced
this pull request
Apr 10, 2025
Summary: D72276082 added support for RMSNorm in the Turing compiler, this diff does the same for Jarvis and removes redundant op registrations. Reviewed By: ThomasJannaud Differential Revision: D72802423
Vysarat
force-pushed
the
export-D72802423
branch
from
1fd9ef7 to
0fbbc66
Compare
Vysarat
added a commit
to Vysarat/executorch
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: pytorch#10074 D72276082 added support for RMSNorm in the Turing compiler, this diff does the same for Jarvis and removes redundant op registrations. Reviewed By: ThomasJannaud Differential Revision: D72802423
Vysarat
force-pushed
the
export-D72802423
branch
from
0fbbc66 to
97f2e8b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72802423 |
Vysarat
added a commit
to Vysarat/executorch
that referenced
this pull request
Apr 10, 2025
Summary: D72276082 added support for RMSNorm in the Turing compiler, this diff does the same for Jarvis and removes redundant op registrations. Reviewed By: ThomasJannaud Differential Revision: D72802423
Vysarat
force-pushed
the
export-D72802423
branch
from
97f2e8b to
1cf338f
Compare
Vysarat
added a commit
to Vysarat/executorch
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: pytorch#10074 D72276082 added support for RMSNorm in the Turing compiler, this diff does the same for Jarvis and removes redundant op registrations. Reviewed By: ThomasJannaud Differential Revision: D72802423
Vysarat
force-pushed
the
export-D72802423
branch
from
1cf338f to
e3f7962
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72802423 |
Summary: D72276082 added support for RMSNorm in the Turing compiler, this diff does the same for Jarvis and removes redundant op registrations. Reviewed By: ThomasJannaud Differential Revision: D72802423
Vysarat
force-pushed
the
export-D72802423
branch
from
e3f7962 to
b31a122
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72802423 |
tarun292
approved these changes
Apr 11, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Summary: D72276082 added support for RMSNorm in the Turing compiler, this diff does the same for Jarvis and removes redundant op registrations. Differential Revision: D72802423
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
Summary: D72276082 added support for RMSNorm in the Turing compiler, this diff does the same for Jarvis and removes redundant op registrations. Differential Revision: D72802423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: D72276082 added support for RMSNorm in the Turing compiler, this diff does the same for Jarvis and removes redundant op registrations.
Differential Revision: D72802423