Skip to content

Conversation

kirklandsign
Copy link
Contributor

No description provided.

Copy link

pytorch-bot bot commented Apr 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10092

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 7addb25 with merge base 76f2773 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2025
@kirklandsign kirklandsign marked this pull request as ready for review April 11, 2025 00:24
@kirklandsign kirklandsign requested a review from Copilot April 11, 2025 00:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

${AWS_CMD} executorch.aar s3://ossci-android/executorch/release/${VERSION_NAME}/executorch.aar --acl public-read
${AWS_CMD} executorch.aar.sha256sums s3://ossci-android/executorch/release/${VERSION_NAME}/executorch.aar.sha256sums --acl public-read
if [ -z "$VERSION" ]; then
VERSION="snapshot-$(date +"%Y%m%d")"
Copy link
Preview

Copilot AI Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The handling of a missing version in the upload step differs from the earlier build step. Aligning both checks (either by assigning a snapshot version or exiting early consistently) will avoid potential confusion or unexpected workflow behavior.

Suggested change
VERSION="snapshot-$(date +"%Y%m%d")"
echo "No version name specified. Exiting upload step."
exit 1

Copilot uses AI. Check for mistakes.

@kirklandsign kirklandsign added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Apr 11, 2025
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice

@kirklandsign kirklandsign merged commit c66b37d into main Apr 11, 2025
82 of 85 checks passed
@kirklandsign kirklandsign deleted the release-daily-snapshot branch April 11, 2025 19:54
keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants