-
Notifications
You must be signed in to change notification settings - Fork 683
Create daily AAR snapshot #10092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create daily AAR snapshot #10092
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10092
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 7addb25 with merge base 76f2773 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
${AWS_CMD} executorch.aar s3://ossci-android/executorch/release/${VERSION_NAME}/executorch.aar --acl public-read | ||
${AWS_CMD} executorch.aar.sha256sums s3://ossci-android/executorch/release/${VERSION_NAME}/executorch.aar.sha256sums --acl public-read | ||
if [ -z "$VERSION" ]; then | ||
VERSION="snapshot-$(date +"%Y%m%d")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The handling of a missing version in the upload step differs from the earlier build step. Aligning both checks (either by assigning a snapshot version or exiting early consistently) will avoid potential confusion or unexpected workflow behavior.
VERSION="snapshot-$(date +"%Y%m%d")" | |
echo "No version name specified. Exiting upload step." | |
exit 1 |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks nice
No description provided.