Fix compiler warnings in a few places #10165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: There are two places that are emitted warnings, causing builds with -Werror to fail. Neither are correctness issues, but this PR cleans them up to enable build with -Werror. Differential Revision: D72996608
GregoryComer
requested review from
JacobSzwejbka,
kirklandsign,
larryliu0820,
lucylq and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10165
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 7 PendingAs of commit 9058fdf with merge base 39274d8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72996608 |
GregoryComer
added
topic: not user facing
module: runtime
zonglinpeng
approved these changes
Apr 14, 2025
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
Summary: There are two places that are emitting warnings, causing builds with -Werror to fail. Neither are correctness issues, but this PR cleans them up to enable build with -Werror. Differential Revision: D72996608 cc @larryliu0820 @JacobSzwejbka @lucylq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There are two places that are emitting warnings, causing builds with -Werror to fail. Neither are correctness issues, but this PR cleans them up to enable build with -Werror.
Differential Revision: D72996608
cc @larryliu0820 @JacobSzwejbka @lucylq