[ET-VK] Use performant tiled algorithm for 4 bit weight only quantized linear #10205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d linear ## Context As title. Update the default compute shader for weight-only quantized int4 linear to use a tiled algorithm, which should boost performance for `gemm` cases, i.e. where `mat1` is a matrix. ## Changes * Changed `q_4w_linear` name to `q_4w_linear_tiled` name * Update the compute shader to use tiled algorithm Using a value of 3 for `TILE_ROWS`; I expect to add variants which switch between different output tile configurations. Differential Revision: [D73044649](https://our.internmc.facebook.com/intern/diff/D73044649/) [ghstack-poisoned]
This was referenced Apr 10, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10205
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ef07365 with merge base 6d1caca ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
SS-JIA
added a commit
that referenced
this pull request
Apr 15, 2025
…d linear ## Context As title. Update the default compute shader for weight-only quantized int4 linear to use a tiled algorithm, which should boost performance for `gemm` cases, i.e. where `mat1` is a matrix. ## Changes * Changed `q_4w_linear` name to `q_4w_linear_tiled` name * Update the compute shader to use tiled algorithm Using a value of 3 for `TILE_ROWS`; I expect to add variants which switch between different output tile configurations. Differential Revision: [D73044649](https://our.internmc.facebook.com/intern/diff/D73044649/) ghstack-source-id: 278225005 Pull Request resolved: #10205
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73044649 |
trivedivivek
approved these changes
Apr 16, 2025
facebook-github-bot
merged commit b9c8c82
into
gh/SS-JIA/213/base
82 of 87 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
As title. Update the default compute shader for weight-only quantized int4 linear to use a tiled algorithm, which should boost performance for
gemmcases, i.e. wheremat1is a matrix.Changes
q_4w_linearname toq_4w_linear_tilednameUsing a value of 3 for
TILE_ROWS; I expect to add variants which switch between different output tile configurations.Differential Revision: D73044649