[mps] Disable dialect verifier under mps preprocess #10276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As title. With reverting dim_order ops, we are producing an illegal IR, which is OK given we are inside MPS preprocess function which shouldn't adhere to edge_ir constraints. Differential Revision: [D73205726](https://our.internmc.facebook.com/intern/diff/D73205726/) [ghstack-poisoned]
This was referenced Apr 17, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10276
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 12 Unrelated FailuresAs of commit 0b805bd with merge base 06f912d ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
digantdesai
added a commit
that referenced
this pull request
Apr 17, 2025
As title. With reverting dim_order ops, we are producing an illegal IR, which is OK given we are inside MPS preprocess function which shouldn't adhere to edge_ir constraints. Differential Revision: [D73205726](https://our.internmc.facebook.com/intern/diff/D73205726/) ghstack-source-id: 278776370 Pull Request resolved: #10276
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73205726 |
This PR needs a
|
As title. With reverting dim_order ops, we are producing an illegal IR, which is OK given we are inside MPS preprocess function which shouldn't adhere to edge_ir constraints. Differential Revision: [D73205726](https://our.internmc.facebook.com/intern/diff/D73205726/) [ghstack-poisoned]
digantdesai
added a commit
that referenced
this pull request
Apr 18, 2025
Pull Request resolved: #10276 As title. With reverting dim_order ops, we are producing an illegal IR, which is OK given we are inside MPS preprocess function which shouldn't adhere to edge_ir constraints. Differential Revision: [D73205726](https://our.internmc.facebook.com/intern/diff/D73205726/) ghstack-source-id: 278881822
|
This pull request was exported from Phabricator. Differential Revision: D73205726 |
As title. With reverting dim_order ops, we are producing an illegal IR, which is OK given we are inside MPS preprocess function which shouldn't adhere to edge_ir constraints. Differential Revision: [D73205726](https://our.internmc.facebook.com/intern/diff/D73205726/) [ghstack-poisoned]
digantdesai
added a commit
that referenced
this pull request
Apr 18, 2025
Pull Request resolved: #10276 As title. With reverting dim_order ops, we are producing an illegal IR, which is OK given we are inside MPS preprocess function which shouldn't adhere to edge_ir constraints. ghstack-source-id: 278949200 Differential Revision: [D73205726](https://our.internmc.facebook.com/intern/diff/D73205726/)
|
This pull request was exported from Phabricator. Differential Revision: D73205726 |
As title. With reverting dim_order ops, we are producing an illegal IR, which is OK given we are inside MPS preprocess function which shouldn't adhere to edge_ir constraints. Differential Revision: [D73205726](https://our.internmc.facebook.com/intern/diff/D73205726/) [ghstack-poisoned]
digantdesai
added a commit
that referenced
this pull request
Apr 18, 2025
Pull Request resolved: #10276 As title. With reverting dim_order ops, we are producing an illegal IR, which is OK given we are inside MPS preprocess function which shouldn't adhere to edge_ir constraints. ghstack-source-id: 279022456 Differential Revision: [D73205726](https://our.internmc.facebook.com/intern/diff/D73205726/)
|
This pull request was exported from Phabricator. Differential Revision: D73205726 |
As title. With reverting dim_order ops, we are producing an illegal IR, which is OK given we are inside MPS preprocess function which shouldn't adhere to edge_ir constraints. Differential Revision: [D73205726](https://our.internmc.facebook.com/intern/diff/D73205726/) [ghstack-poisoned]
digantdesai
added a commit
that referenced
this pull request
Apr 21, 2025
Pull Request resolved: #10276 As title. With reverting dim_order ops, we are producing an illegal IR, which is OK given we are inside MPS preprocess function which shouldn't adhere to edge_ir constraints. ghstack-source-id: 279282754 Differential Revision: [D73205726](https://our.internmc.facebook.com/intern/diff/D73205726/)
|
This pull request was exported from Phabricator. Differential Revision: D73205726 |
facebook-github-bot
merged commit aba63b3
into
gh/digantdesai/36/base
77 of 93 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Apr 21, 2025
Pull Request resolved: #10276 As title. With reverting dim_order ops, we are producing an illegal IR, which is OK given we are inside MPS preprocess function which shouldn't adhere to edge_ir constraints. ghstack-source-id: 279282754 Differential Revision: [D73205726](https://our.internmc.facebook.com/intern/diff/D73205726/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As title. With reverting dim_order ops, we are producing an illegal IR, which is OK given we are inside MPS preprocess function which shouldn't adhere to edge_ir constraints.
Differential Revision: D73205726