[ET-VK][ez] Streamline + fix enabling device extensions #10352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes Simplify the logic to construct a linked list of physical device feature structs When constructing the logical device, construct the linked list of device features to enable instead of using a stored pointer from the constructor of `PhysicalDevice`. The reason is that due to possible moves, the stored pointer may be invalid by the time the `Adapter` instance is constructed. It is safer to reconstruct the device features linked list at the time it is needed. Differential Revision: [D73438721](https://our.internmc.facebook.com/intern/diff/D73438721/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10352
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit f7d5cf3 with merge base 95c663e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73438721 |
junpi3
approved these changes
Apr 22, 2025
## Changes Simplify the logic to construct a linked list of physical device feature structs When constructing the logical device, construct the linked list of device features to enable instead of using a stored pointer from the constructor of `PhysicalDevice`. The reason is that due to possible moves, the stored pointer may be invalid by the time the `Adapter` instance is constructed. It is safer to reconstruct the device features linked list at the time it is needed. Differential Revision: [D73438721](https://our.internmc.facebook.com/intern/diff/D73438721/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D73438721 |
facebook-github-bot
merged commit 40ee03f
into
gh/SS-JIA/217/base
86 of 87 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Changes
Simplify the logic to construct a linked list of physical device feature structs
When constructing the logical device, construct the linked list of device features to enable instead of using a stored pointer from the constructor of
PhysicalDevice. The reason is that due to possible moves, the stored pointer may be invalid by the time theAdapterinstance is constructed. It is safer to reconstruct the device features linked list at the time it is needed.Differential Revision: D73438721