Skip to content

[Android] Support 16bit output data as raw data byte[] #10412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kirklandsign wants to merge 2 commits into from
Closed

[Android] Support 16bit output data as raw data byte[] #10412

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e2106c
[Android] Support 16bit data as raw data byte[]
kirklandsign Apr 23, 2025
833d388
Update Tensor.java
kirklandsign Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions extension/android/executorch_android/src/main/java/org/pytorch/executorch/Tensor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,44 @@ public String toString() {
}
}

/**
* A generic holder for 16b (fp16/bfloat16) tensor. Not intended for general use. User can only
* use #Tensor.getDataAsUnsignedByteArray() to get raw bytes. Users need to parse it.
*/
static class Tensor_raw_data_16b extends Tensor {
private final ByteBuffer data;
private final DType myDtype;

private Tensor_raw_data_16b(ByteBuffer data, long[] shape, DType dtype) {
super(shape);
this.data = data;
this.myDtype = dtype;
}

@Override
public DType dtype() {
return myDtype;
}

@Override
Buffer getRawDataBuffer() {
return data;
}

@Override
public byte[] getDataAsUnsignedByteArray() {
data.rewind();
byte[] arr = new byte[data.remaining()];
data.get(arr);
return arr;
}

@Override
public String toString() {
return String.format("Tensor(%s, dtype=%d)", Arrays.toString(shape), this.myDtype);
}
}

// region checks
private static void checkArgument(boolean expression, String errorMessage, Object... args) {
if (!expression) {
Expand Down Expand Up @@ -674,6 +712,10 @@ private static Tensor nativeNewTensor(
tensor = new Tensor_uint8(data, shape);
} else if (DType.INT8.jniCode == dtype) {
tensor = new Tensor_int8(data, shape);
} else if (DType.HALF.jniCode == dtype) {
tensor = new Tensor_raw_data_16b(data, shape, DType.HALF);
} else if (DType.HALF.jniCode == dtype) {
Copy link
Contributor

@phaiting phaiting Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is same check as L715, should be DType.BFLOAT16.jniCode == dtype?

tensor = new Tensor_raw_data_16b(data, shape, DType.BFLOAT16);
} else {
throw new IllegalArgumentException("Unknown Tensor dtype");
}
Expand Down
Loading