Skip to content

Conversation

@JacobSzwejbka
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka commented Apr 23, 2025

Summary:
Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877

cc @larryliu0820 @mergennachin @cccclai @helunwencser @jackzhxng

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10418

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job

As of commit 9f8dac0 with merge base f98273c (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Apr 29, 2025
Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Apr 29, 2025
Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450877

@JacobSzwejbka JacobSzwejbka added module: llm Issues related to LLM examples and apps, and to the extensions/llm/ code release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) labels Apr 29, 2025
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Apr 29, 2025
Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request May 5, 2025
Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request May 5, 2025
Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request May 5, 2025
Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request May 5, 2025
Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 14, 2025
Summary:
Pull Request resolved: pytorch#10418

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 15, 2025
Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450877

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 16, 2025
Summary:
Pull Request resolved: pytorch#10418

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Reviewed By: larryliu0820

Differential Revision: D73450877
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 16, 2025
Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Reviewed By: larryliu0820

Differential Revision: D73450877
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 16, 2025
Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Reviewed By: larryliu0820

Differential Revision: D73450877
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 16, 2025
Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Reviewed By: larryliu0820

Differential Revision: D73450877
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 16, 2025
Summary:
Pull Request resolved: pytorch#10418

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Reviewed By: larryliu0820

Differential Revision: D73450877
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 16, 2025
Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Reviewed By: larryliu0820

Differential Revision: D73450877
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450877

Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Reviewed By: larryliu0820

Differential Revision: D73450877
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450877

@SS-JIA SS-JIA merged commit e515079 into pytorch:main Jul 17, 2025
97 of 103 checks passed
lucylq pushed a commit that referenced this pull request Jul 17, 2025
Summary:
Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877




cc @larryliu0820 @mergennachin @cccclai @helunwencser @jackzhxng
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported module: llm Issues related to LLM examples and apps, and to the extensions/llm/ code release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants