-
Notifications
You must be signed in to change notification settings - Fork 741
Fix numel() downcast in executorch/backends/vulkan/test/utils/test_utils.cpp +2
#10419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…utils.cpp +2 Summary: `numel()` has type `int64_t`. The implicit downcasts fix in this change artificially truncate data ranges which can lead to hard-to-debug errors and SEVs. Using `auto` ensures that the correct data type is used. Reviewed By: dtolnay Differential Revision: D73534006
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10419
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit a536e23 with merge base 954f2cb ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D73534006 |
This PR needs a
|
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Summary:
numel()has typeint64_t. The implicit downcasts fix in this change artificially truncate data ranges which can lead to hard-to-debug errors and SEVs. Usingautoensures that the correct data type is used.Reviewed By: dtolnay
Differential Revision: D73534006
cc @SS-JIA @manuelcandales @cbilgin