Skip to content

Add pass to tag external constants for delegates #10422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

Add pass to tag external constants for delegates #10422

merged 1 commit into from
Apr 24, 2025

Conversation

@pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #10328 by @lucylq
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/63/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/63/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/63/orig
@diff-train-skip-merge

@lucylq
Add pass to tag external constants for delegates
19535f8 
Pull Request resolved: #10328

generate pte+ptd file for a delegated linear example
ghstack-source-id: 279823594

Differential Revision: [D73281924](https://our.internmc.facebook.com/intern/diff/D73281924/)
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10422

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 20 Pending

As of commit 19535f8 with merge base 334af4a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@jackzhxng jackzhxng merged commit c210472 into main Apr 24, 2025
82 of 85 checks passed
@jackzhxng jackzhxng deleted the gh/lucylq/63/orig branch April 24, 2025 00:28
GregoryComer
GregoryComer reviewed May 1, 2025
View reviewed changes
backends/xnnpack/operators/node_visitor.py
)

external_tag = tensor.meta.get("delegate_constant_tag", None)
logging.info(
Copy link
Member

@GregoryComer GregoryComer May 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucylq Can we reduce the log verbosity, maybe moving to debug level? Might be good to reduce the out-of-box log volume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GregoryComer GregoryComer GregoryComer left review comments

@jackzhxng jackzhxng jackzhxng approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@tarun292 tarun292 Awaiting requested review from tarun292

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

@mcr229 mcr229 Awaiting requested review from mcr229

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pytorchbot @GregoryComer @jackzhxng @facebook-github-bot @lucylq