Skip to content
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/scripts/extract_benchmark_results.py
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,10 @@ def transform(
# Overwrite the device name here with the job name as it has more information about
# the device, i.e. Samsung Galaxy S22 5G instead of just Samsung
for r in benchmark_results:
r["deviceInfo"]["device"] = job_name
is_private_device = job_report.get("is_private_instance", False)
r["deviceInfo"]["device"] = (
f"{job_name} (private)" if is_private_device else job_name
)

# From https://github.com/pytorch/pytorch/wiki/How-to-integrate-with-PyTorch-OSS-benchmark-database
return [
Expand All @@ -363,6 +366,7 @@ def transform(
"benchmark_config": json.dumps(benchmark_config),
"job_conclusion": "SUCCESS",
"job_arn": job_report.get("arn", ""),
"instance_arn": job_report.get("instance_arn", ""),
},
},
"model": {
Expand Down
16 changes: 7 additions & 9 deletions .github/workflows/apple-perf-private-device-experiment.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,16 @@
name: apple-perf (private devices)

on:
# TODO (huydhn): Disable the schedule run until we land the change to add device pool and device name
# to separate between public and private iOS devices
# schedule:
# - cron: 0 0,4,8,12,16,20 * * *
schedule:
- cron: 0 0,4,8,12,16,20 * * *
pull_request:
paths:
- .github/workflows/apple-perf-private-device-experiment.yml
# push:
# branches:
# - main
# paths:
# - .github/workflows/apple-perf-private-device-experiment.yml
push:
branches:
- main
paths:
- .github/workflows/apple-perf-private-device-experiment.yml
# Note: GitHub has an upper limit of 10 inputs
workflow_dispatch:
inputs:
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/apple-perf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,8 @@ jobs:
permissions:
id-token: write
contents: read
uses: pytorch/test-infra/.github/workflows/mobile_job.yml@main
# TESTING
uses: pytorch/test-infra/.github/workflows/mobile_job.yml@add-device-type-and-id
strategy:
matrix: ${{ fromJson(needs.set-parameters.outputs.benchmark_configs) }}
fail-fast: false
Expand All @@ -446,7 +447,8 @@ jobs:
device-type: ios
# For iOS testing, the runner just needs to call AWS Device Farm, so there is no need to run this on macOS
runner: linux.2xlarge
test-infra-ref: ''
# TESTING
test-infra-ref: add-device-type-and-id
# This is the ARN of ExecuTorch project on AWS
project-arn: arn:aws:devicefarm:us-west-2:308535385114:project:02a2cf0f-6d9b-45ee-ba1a-a086587469e6
device-pool-arn: ${{ matrix.device_arn }}
Expand Down
2 changes: 1 addition & 1 deletion extension/llm/tokenizers
Loading