Skip to content

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Apr 25, 2025

Stack from ghstack (oldest at bottom):

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change all the inputs.

Differential Revision: D73470865

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change all the inputs.

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)

[ghstack-poisoned]
@lucylq lucylq requested a review from shoumikhin as a code owner April 25, 2025 23:40
Copy link

pytorch-bot bot commented Apr 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10497

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit f355971 with merge base 0165a02 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

lucylq added a commit that referenced this pull request Apr 25, 2025
Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change all the inputs.

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)

ghstack-source-id: 280423097
Pull Request resolved: #10497
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 25, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73470865

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change all the inputs.

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 26, 2025
Pull Request resolved: #10497

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change all the inputs.
ghstack-source-id: 280434546
@exported-using-ghexport

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73470865

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change all the inputs.

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 28, 2025
Pull Request resolved: #10497

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change the inputs.

ghstack-source-id: 280783094
@exported-using-ghexport

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73470865

Copy link
Contributor

@JacobSzwejbka JacobSzwejbka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change all the inputs.

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 28, 2025
Pull Request resolved: #10497

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change the inputs.

ghstack-source-id: 280799749
@exported-using-ghexport

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73470865

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change all the inputs.

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 28, 2025
Pull Request resolved: #10497

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change the inputs.

ghstack-source-id: 280809992
@exported-using-ghexport

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73470865

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change all the inputs.

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 29, 2025
Pull Request resolved: #10497

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change the inputs.

ghstack-source-id: 280963439
@exported-using-ghexport

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73470865

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change all the inputs.

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 29, 2025
Pull Request resolved: #10497

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change the inputs.

ghstack-source-id: 281037656
@exported-using-ghexport

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73470865

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change all the inputs.

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 29, 2025
Pull Request resolved: #10497

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change the inputs.

ghstack-source-id: 281063273
@exported-using-ghexport

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73470865

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change all the inputs.

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)

[ghstack-poisoned]
@lucylq lucylq requested a review from kirklandsign as a code owner April 30, 2025 00:19
lucylq added a commit that referenced this pull request Apr 30, 2025
Pull Request resolved: #10497

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change the inputs.

ghstack-source-id: 281075681
@exported-using-ghexport

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73470865

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change all the inputs.

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 30, 2025
Pull Request resolved: #10497

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change the inputs.

ghstack-source-id: 281075681
@exported-using-ghexport

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73470865

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change all the inputs.

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 30, 2025
Pull Request resolved: #10497

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change the inputs.

ghstack-source-id: 281217363
@exported-using-ghexport

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73470865

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change all the inputs.

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Apr 30, 2025
Pull Request resolved: #10497

Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change the inputs.

ghstack-source-id: 281246351
@exported-using-ghexport

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73470865

@facebook-github-bot facebook-github-bot merged commit ee829b7 into gh/lucylq/67/base Apr 30, 2025
91 of 94 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/lucylq/67/head branch April 30, 2025 22:01
lucylq added a commit that referenced this pull request Apr 30, 2025
Instead of checking in the PTE/PTD files. This helps us keep up to date with aot changes, especially with incoming flat_tensor refactor.

Main changes here are with the model. Instead of using AddModule from examples/portable, use ModuleAdd from test/models/export_program, like our other tests. There is a shape difference (1 tensor vs 2 tensors+alpha), so we have to change all the inputs.

Differential Revision: [D73470865](https://our.internmc.facebook.com/intern/diff/D73470865/)

This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #10497 by
@lucylq
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/lucylq/67/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/lucylq/67/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/lucylq/67/orig
@diff-train-skip-merge

Co-authored-by: lucylq <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants