Allow removing permute pairs in addition to transpose pairs #10501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10501
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ec11f8d with merge base c5dd476 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73619452 |
mcremon-meta
added a commit
that referenced
this pull request
Apr 26, 2025
Summary: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further, task is T222295719 Reviewed By: zonglinpeng Differential Revision: D73619452
mcremon-meta
force-pushed
the
export-D73619452
branch
from
dcdf077 to
16a084f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73619452 |
mcremon-meta
added a commit
that referenced
this pull request
Apr 26, 2025
Summary: Pull Request resolved: #10501 As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further, task is T222295719 Reviewed By: zonglinpeng Differential Revision: D73619452
mcremon-meta
force-pushed
the
export-D73619452
branch
from
16a084f to
eaedd4d
Compare
dulinriley
approved these changes
Apr 28, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 29, 2025
Summary: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further, task is T222295719 Differential Revision: D73619452
facebook-github-bot
force-pushed
the
export-D73619452
branch
from
eaedd4d to
eab834e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73619452 |
ThomasJannaud
added a commit
that referenced
this pull request
Apr 29, 2025
Summary: Pull Request resolved: #10501 As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further, task is T222295719 Differential Revision: D73619452
|
This pull request was exported from Phabricator. Differential Revision: D73619452 |
ThomasJannaud
force-pushed
the
export-D73619452
branch
from
eab834e to
2fbf300
Compare
facebook-github-bot
force-pushed
the
export-D73619452
branch
from
2fbf300 to
2c34c2a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73619452 |
ThomasJannaud
force-pushed
the
export-D73619452
branch
from
2c34c2a to
673e85a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73619452 |
mcremon-meta
pushed a commit
that referenced
this pull request
Apr 29, 2025
Summary: Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Differential Revision: D73619452
mcremon-meta
force-pushed
the
export-D73619452
branch
from
673e85a to
871ef8e
Compare
Summary: Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Differential Revision: D73619452
facebook-github-bot
force-pushed
the
export-D73619452
branch
from
871ef8e to
ec11f8d
Compare
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 29, 2025
…10501) Summary: Pull Request resolved: pytorch#10501 Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Differential Revision: D73619452
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: pytorch#10566 Pull Request resolved: pytorch#10501 Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: pytorch#10566 Pull Request resolved: pytorch#10501 Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: pytorch#10566 Pull Request resolved: pytorch#10501 Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: pytorch#10566 Pull Request resolved: pytorch#10501 Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: pytorch#10566 Pull Request resolved: pytorch#10501 Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: pytorch#10566 Pull Request resolved: pytorch#10501 Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
ThomasJannaud
added a commit
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Differential Revision: D73619452 Co-authored-by: Thomas Jannaud <[email protected]>
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As titled. Gets us 27% better cycles on Activity Classification (at opt level 3).
Can be improved further, task is T222295719
Reviewed By: zonglinpeng
Differential Revision: D73619452