[ET-VK] Using uint16 for quantized linear tiling shader to reduce register pressure and improve performance. #10509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk to improve thread occupancy and performance. This diff changes tiled 8 bit quantized linear mat mul op to linearly dispatch work which increases thread occupancy and improves performance. Differential Revision: [D73751979](https://our.internmc.facebook.com/intern/diff/D73751979/) [ghstack-poisoned]
…ister pressure and improve performance. This diff reduces int precision for certain variables in 8 bit quantized tiled linear op to reduce register pressure and improve performance. Differential Revision: [D73752090](https://our.internmc.facebook.com/intern/diff/D73752090/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10509
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
trivedivivek
added a commit
that referenced
this pull request
Apr 28, 2025
…ister pressure and improve performance. This diff reduces int precision for certain variables in 8 bit quantized tiled linear op to reduce register pressure and improve performance. Differential Revision: [D73752090](https://our.internmc.facebook.com/intern/diff/D73752090/) ghstack-source-id: 280586466 Pull Request resolved: #10509
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73752090 |
…tiling shader to reduce register pressure and improve performance." This diff reduces int precision for certain variables in 8 bit quantized tiled linear op to reduce register pressure and improve performance. Differential Revision: [D73752090](https://our.internmc.facebook.com/intern/diff/D73752090/) [ghstack-poisoned]
… reduce register pressure and improve performance." This diff reduces int precision for certain variables in 8 bit quantized tiled linear op to reduce register pressure and improve performance. Differential Revision: [D73752090](https://our.internmc.facebook.com/intern/diff/D73752090/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
Apr 28, 2025
…ister pressure and improve performance. Pull Request resolved: #10509 This diff reduces int precision for certain variables in 8 bit quantized tiled linear op to reduce register pressure and improve performance. ghstack-source-id: 280651868 @exported-using-ghexport Differential Revision: [D73752090](https://our.internmc.facebook.com/intern/diff/D73752090/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73752090 |
SS-JIA
approved these changes
Apr 28, 2025
…tiling shader to reduce register pressure and improve performance." This diff reduces int precision for certain variables in 8 bit quantized tiled linear op to reduce register pressure and improve performance. Differential Revision: [D73752090](https://our.internmc.facebook.com/intern/diff/D73752090/) [ghstack-poisoned]
… reduce register pressure and improve performance." This diff reduces int precision for certain variables in 8 bit quantized tiled linear op to reduce register pressure and improve performance. Differential Revision: [D73752090](https://our.internmc.facebook.com/intern/diff/D73752090/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
Apr 28, 2025
…ister pressure and improve performance. Pull Request resolved: #10509 This diff reduces int precision for certain variables in 8 bit quantized tiled linear op to reduce register pressure and improve performance. ghstack-source-id: 280715504 @exported-using-ghexport Differential Revision: [D73752090](https://our.internmc.facebook.com/intern/diff/D73752090/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73752090 |
…tiling shader to reduce register pressure and improve performance." This diff reduces int precision for certain variables in 8 bit quantized tiled linear op to reduce register pressure and improve performance. Differential Revision: [D73752090](https://our.internmc.facebook.com/intern/diff/D73752090/) [ghstack-poisoned]
… reduce register pressure and improve performance." This diff reduces int precision for certain variables in 8 bit quantized tiled linear op to reduce register pressure and improve performance. Differential Revision: [D73752090](https://our.internmc.facebook.com/intern/diff/D73752090/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
Apr 28, 2025
…ister pressure and improve performance. Pull Request resolved: #10509 This diff reduces int precision for certain variables in 8 bit quantized tiled linear op to reduce register pressure and improve performance. ghstack-source-id: 280719995 @exported-using-ghexport Differential Revision: [D73752090](https://our.internmc.facebook.com/intern/diff/D73752090/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73752090 |
…tiling shader to reduce register pressure and improve performance." This diff reduces int precision for certain variables in 8 bit quantized tiled linear op to reduce register pressure and improve performance. Differential Revision: [D73752090](https://our.internmc.facebook.com/intern/diff/D73752090/) [ghstack-poisoned]
… reduce register pressure and improve performance." This diff reduces int precision for certain variables in 8 bit quantized tiled linear op to reduce register pressure and improve performance. Differential Revision: [D73752090](https://our.internmc.facebook.com/intern/diff/D73752090/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
Apr 28, 2025
…ister pressure and improve performance. Pull Request resolved: #10509 This diff reduces int precision for certain variables in 8 bit quantized tiled linear op to reduce register pressure and improve performance. ghstack-source-id: 280739898 @exported-using-ghexport Differential Revision: [D73752090](https://our.internmc.facebook.com/intern/diff/D73752090/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73752090 |
SS-JIA
pushed a commit
that referenced
this pull request
Apr 28, 2025
…rk to improve thread occupancy and performance. (#10508) Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #10509 * __->__ #10508 This diff changes tiled 8 bit quantized linear mat mul op to linearly dispatch work which increases thread occupancy and improves performance. Differential Revision: [D73751979](https://our.internmc.facebook.com/intern/diff/D73751979/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff reduces int precision for certain variables in 8 bit quantized tiled linear op to reduce register pressure and improve performance.
Differential Revision: D73752090