Skip to content

Fix coreml rank0 #10534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 30, 2025
Merged

Fix coreml rank0 #10534

merged 7 commits into from
Apr 30, 2025

Conversation

metascroy
Copy link
Contributor

coremltools wraps rank 0 tensors as rank1 tensors in the AOT flow when producing a PTE file. This PR:

  • Applies the same change on the coreml runtime
  • Changes CoreML model tests to use the partitioner

Fixes #10451

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10534

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 6 Pending

As of commit b10783e with merge base c5dd476 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 28, 2025
@metascroy metascroy requested a review from YifanShenSZ April 28, 2025 22:55
YifanShenSZ
YifanShenSZ approved these changes Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@YifanShenSZ YifanShenSZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the neat fix! Yes wrapping also in coreml delegate runtime is a neat solution

@metascroy metascroy merged commit 31f828c into main Apr 30, 2025
275 of 276 checks passed
@metascroy metascroy deleted the fix-coreml-rank0 branch April 30, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shoumikhin shoumikhin shoumikhin approved these changes

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

+1 more reviewer

@YifanShenSZ YifanShenSZ YifanShenSZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CoreML Partitioner is not able to lower mv3

4 participants

@metascroy @shoumikhin @YifanShenSZ @facebook-github-bot