Skip to content

Android fix uninitialized temperature #10619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shoumikhin merged 2 commits into from
May 1, 2025
Merged

Android fix uninitialized temperature #10619

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d27f44
Android fix uninitialized temperature
kirklandsign May 1, 2025
987b7d1
Merge branch 'main' into android-fix-temperature
shoumikhin May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion extension/android/jni/jni_layer_llama.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ class ExecuTorchLlmCallbackJni
class ExecuTorchLlmJni : public facebook::jni::HybridClass<ExecuTorchLlmJni> {
private:
friend HybridBase;
float temperature_;
float temperature_ = 0.0f;
int model_type_category_;
std::unique_ptr<llm::IRunner> runner_;
std::unique_ptr<llm::MultimodalRunner> multi_modal_runner_;
Expand Down Expand Up @@ -146,6 +146,7 @@ class ExecuTorchLlmJni : public facebook::jni::HybridClass<ExecuTorchLlmJni> {
facebook::jni::alias_ref<jstring> tokenizer_path,
jfloat temperature,
facebook::jni::alias_ref<jstring> data_path = nullptr) {
temperature_ = temperature;
#if defined(ET_USE_THREADPOOL)
// Reserve 1 thread for the main thread.
int32_t num_performant_cores =
Expand Down
Loading