Make quantize_pt2 private and remove external call sites #10683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10683
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit be92c5e with merge base 3ffb704 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74096228 |
ThomasJannaud
approved these changes
May 5, 2025
mcremon-meta
added a commit
that referenced
this pull request
May 5, 2025
Summary: As titled. Reviewed By: zonglinpeng, hsharma35 Differential Revision: D74096228
mcremon-meta
force-pushed
the
export-D74096228
branch
from
f43acf2 to
654b301
Compare
Summary: Pull Request resolved: #10683 As titled. Reviewed By: zonglinpeng, hsharma35 Differential Revision: D74096228
|
This pull request was exported from Phabricator. Differential Revision: D74096228 |
mcremon-meta
force-pushed
the
export-D74096228
branch
from
654b301 to
be92c5e
Compare
phaiting
pushed a commit
that referenced
this pull request
May 6, 2025
Differential Revision: D74096228 Pull Request resolved: #10683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled.
Reviewed By: hsharma35
Differential Revision: D74096228