Skip to content

Fix preq embedding dtype check #10699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix preq embedding dtype check #10699

wants to merge 1 commit into from

Conversation

@YIWENX14
Copy link
Contributor

@YIWENX14 YIWENX14 commented May 5, 2025

Differential Revision: D74194622

@YIWENX14 YIWENX14 requested review from jackzhxng and lucylq as code owners May 5, 2025 22:23
@pytorch-bot
Copy link

pytorch-bot bot commented May 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10699

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit e7f0ba4 with merge base 1c2b7ba (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 5, 2025

This pull request was exported from Phabricator. Differential Revision: D74194622

@YIWENX14
Copy link
Contributor Author

YIWENX14 commented May 9, 2025

@pytorchbot label "topic: not user facing"

@YIWENX14 @facebook-github-bot
Fix preq embedding dtype check (pytorch#10699)
e7f0ba4 
Summary:



Rollback Plan:

Differential Revision: D74194622
@YIWENX14 YIWENX14 force-pushed the export-D74194622 branch from 06c47bf to e7f0ba4 Compare May 9, 2025 22:09
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 9, 2025

This pull request was exported from Phabricator. Differential Revision: D74194622

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Sep 1, 2025
@jackzhxng jackzhxng closed this Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported stale PRs inactive for over 60 days topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YIWENX14 @facebook-github-bot @jackzhxng